I am trying to set up a Minecraft server and everything in that department went well, but my friend still can not join. I've narrowed the problem to be with my port forwarding most likely. I thought I set up port forwarding, but when I use a port forward tester, it still says the port is closed. So between that and everything else seeming to be working completely fine, I think it has to do with that.

I know that others need to use your public IP to join your server (I have a Dynamic IP, not a Static one, but I messed around with some DNS software and I think I fixed it) So when I went to my IP's website and found port forwarding under NAT Forwarding, I began to fill out the information.

I put DNS for the device even though I wasn't completely sure what that meant. I put my IPv4 for the remote address. I put 25565 (Minecraft port) for both the external and internal ports. Then I put All for the protocol. It didn't ask me to save or apply changes but when I refreshed my thing was still there. I'm really stumped as to what the problem is. If anyone can help me it would be much appreciated.